search

google / gvisor

Application Kernel for Containers
https://gvisor.dev
Apache License 2.0
15.56k stars 1.28k forks source link

Feature request: runsc --version #39

Closed chanwit closed 6 years ago

chanwit commented 6 years ago

Need a kind of version number, probably in the form of git commit. This would be great when reporting bugs back to the project.

chanwit commented 6 years ago

@hugelgupf @fvoznika I'm about to submit patch to Gerrit. Am I allowed to do so? Already registered there by username at gmail dot com.

chanwit commented 6 years ago

CLA is signed.

hugelgupf commented 6 years ago

Go for it.

chanwit commented 6 years ago

Thank you @hugelgupf Quick question on how the workflow is working?

It seems I am not allowed to push changes to /refs/for/master (rejected) . Also I cannot push to a new branch /refs/for/add_version (my current dev branch). Do I need to manually create a branch on Gerrit? Asked because everyone there reviewing on the master branch.

chanwit commented 6 years ago

@hugelgupf never mind. Done by tweaking .git/config.

Here's the changes: https://gvisor-review.googlesource.com/c/gvisor/+/2020

nlacasse commented 6 years ago

The git revision is now displayed in the debug block at the beginning of the output.