google / gvisor

Application Kernel for Containers
https://gvisor.dev
Apache License 2.0
15.53k stars 1.28k forks source link

TAP devices should have a link address #4582

Open ghananigans opened 3 years ago

ghananigans commented 3 years ago

https://github.com/google/gvisor/blob/257703c050e5901aeb3734f200f5a6b41856b4d9/pkg/tcpip/link/tun/device.go#L155

TAP devices do not have a link address when it is created. TAP devices emulate a link-layer device device sending ethernet framse.

github-actions[bot] commented 11 months ago

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] commented 8 months ago

This issue has been closed due to lack of activity.

github-actions[bot] commented 8 months ago

There are TODOs still referencing this issue:

  1. pkg/tcpip/network/arp/arp.go:198: check copied length once TAP devices have a
  2. pkg/tcpip/network/arp/arp.go:339: check copied length once TAP devices have a

Search TODO

github-actions[bot] commented 4 months ago

A friendly reminder that this issue had no activity for 120 days.