search

google / gvisor

Application Kernel for Containers
https://gvisor.dev
Apache License 2.0
15.58k stars 1.28k forks source link

Improve documentation for ARM64 ring0/entry_arm64.s #4870

Open hbhasker opened 3 years ago

hbhasker commented 3 years ago

entry_arm64.s has large parts of ARM specific assembly that doesn't have proper documentation. It would be helpful for future maintainers to include references to specific ARM manuals or a better description of each assembly function.

Same goes for lib_arm64.s where functions could use some descriptions w/ references.

avagin commented 3 years ago

Cc: @lubinszARM

lubinszARM commented 3 years ago

I see. @hbhasker I will sort out the documents related to GOASM and ARM in these files. Thanks.

lubinszARM commented 3 years ago

Hi @hbhasker Can tell me your email? Let me send you some files related to GOASM and ARM spec? Thanks.

avagin commented 3 years ago

@lubinszARM you can share them here. I think it will be interesting for others too. And you can find bhasker's email in the git history.

lubinszARM commented 3 years ago

goasm_arm64.zip

lubinszARM commented 3 years ago

Arm Architecture Reference Manual Armv8, for Armv8-A architecture profile https://developer.arm.com/documentation/ddi0487/latest/

lubinszARM commented 3 years ago

Please take a look, if have any other questions, please let me know. :)

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.