search

google / gvisor

Application Kernel for Containers
https://gvisor.dev
Apache License 2.0
15.85k stars 1.3k forks source link

Compose tcp.endpoint with network.Endpoint #6974

Open arthurpi opened 2 years ago

arthurpi commented 2 years ago

Description

transport/internal/network.Endpoint implements common facilities shared to send/receive datagrams over a network protocol. UDP, ICMP, RAW endpoints are composed with that type.

We can treat each TCP segment as a network datagram, so tcp.endpoint can be composed by a transport/internal/network.Endpoint. This will lead to reduced code duplication.

Steps to reproduce

No response

runsc version

No response

docker version (if using docker)

No response

uname

No response

kubectl (if using Kubernetes)

No response

repo state (if built from source)

No response

runsc debug logs (if available)

No response

github-actions[bot] commented 1 year ago

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] commented 11 months ago

This issue has been closed due to lack of activity.

github-actions[bot] commented 11 months ago

There are TODOs still referencing this issue:

  1. pkg/tcpip/transport/tcp/endpoint.go:805: Remove once tcp endpoints are composed with a

Search TODO

github-actions[bot] commented 7 months ago

A friendly reminder that this issue had no activity for 120 days.