search

google / gvisor

Application Kernel for Containers
https://gvisor.dev
Apache License 2.0
15.74k stars 1.29k forks source link

SO_REUSEPORT not properly restored #873

Open iangudger opened 5 years ago

iangudger commented 5 years ago

SO_REUSEPORT is implemented with a middleware endpoint in the transport demuxing path called multiPortEndpoint. It is currently regenerated on restore with a different randomly generated seed. In addition, the endpoints may not be re-registered with it in the same order. This will cause the behavior of SO_REUSEPORT to change across a S/R event in a user visible and incorrect way.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 4 years ago

There are TODOs still referencing this issue:

  1. pkg/tcpip/stack/transport_demuxer.go:319: Restore this properly. Currently, we just save
  2. test/syscalls/linux/socket_ipv4_udp_unbound.cc:1688: Endpoint order is not restored correctly. Enable
  3. test/syscalls/linux/socket_ipv4_udp_unbound.cc:1711: Endpoint order is not restored correctly.

Search TODO

github-actions[bot] commented 1 year ago

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] commented 10 months ago

This issue has been closed due to lack of activity.

github-actions[bot] commented 10 months ago

There are TODOs still referencing this issue:

  1. pkg/tcpip/stack/transport_demuxer.go:336: Restore this properly. Currently, we just save
  2. test/syscalls/linux/socket_ipv4_udp_unbound.cc:1458: Endpoint order is not restored correctly. Enable
  3. test/syscalls/linux/socket_ipv4_udp_unbound.cc:1479: Endpoint order is not restored correctly.

Search TODO

github-actions[bot] commented 6 months ago

A friendly reminder that this issue had no activity for 120 days.