search

google / gwtmockito

Better GWT unit testing
https://google.github.io/gwtmockito
Apache License 2.0
157 stars 50 forks source link

@GwtMock is not initialized for parent class members #12

Closed justinmk closed 11 years ago

justinmk commented 11 years ago

For test groups that share common setup() and member variables, it is useful to define a base class that includes common mocks, to avoid boilerplate. Mockito supports this for @Mock. GwtMockito can support it with this small modification.

ekuefler commented 11 years ago

We should definitely be consistent with what Mockito does here - thanks for the patch! The indentation you're using here is inconsistent with the rest of GwtMockito - everywhere else uses a two space indent (four for line continuations) using spaces only, no tabs. Would you mind cleaning that up before I merge?

justinmk commented 11 years ago

No problem. Thanks for an elegant library.

justinmk commented 11 years ago

Amended the commit, whitespace should be fixed now.

ekuefler commented 11 years ago

Merged. Thanks!