hashCode and equals proxying fix

google / gwtmockito

Better GWT unit testing

https://google.github.io/gwtmockito

Apache License 2.0

157 stars 50 forks source link

hashCode and equals proxying fix #68

Closed zolv closed 7 years ago

zolv commented 7 years ago

Fixing a problem with hashCode method causing this exception: Caused by: java.lang.IllegalArgumentException: hashCode must return either String or SafeHtml at com.google.gwtmockito.fakes.ExtendedFakeMessagesProvider$1.invoke(ExtendedFakeMessagesProvider.java:61) at com.sun.proxy.$Proxy8.hashCode(Unknown Source) ...

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

zolv commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

ekuefler commented 7 years ago

This looks good, thanks for the fix. Could you add a test called shouldGenerateHashCodeForMessages at https://github.com/google/gwtmockito/blob/master/gwtmockito/src/test/java/com/google/gwtmockito/GwtMockitoTest.java#L163?

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.