Make jdk.internal.reflect package being loaded by the standard classloader

[benoitf]

It avoids error like

Caused by: java.lang.IllegalAccessError: class jdk.internal.reflect.ConstructorAccessorImpl loaded by com/google/gwtmockito/GwtMockitoTestRunner$GwtMockitoClassLoader cannot access jdk/internal/reflect superclass jdk.internal.reflect.MagicAccessorImpl
    at java.base/java.lang.ClassLoader.defineClass1(Native Method)
    at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1007)
    at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:868)
    at javassist.Loader.findClass(Loader.java:377)
    at com.google.gwtmockito.GwtMockitoTestRunner$GwtMockitoClassLoader.findClass(GwtMockitoTestRunner.java:421)

when you're using Java9

With that patch, I'm able to successfully build gwtmockito with Oracle Java9

java version "9.0.1"
Java(TM) SE Runtime Environment (build 9.0.1+11)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)

It would be nice to have this as part of the project instead of having to override getPackagesToLoadViaStandardClassloader() method in custom runnner or to use

@WithPackagesToLoadViaStandardClassLoader(value = "jdk.internal.reflect")

I've tested and build is working with Java8 and Java9

It could be related to issue https://github.com/google/gwtmockito/issues/72

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[googlebot]

CLAs look good, thanks!

[benoitf]

@ekuefler do you have ETA for 1.1.8 release ?

[ekuefler]

Not yet, you just barely missed 1.1.7. We're doing some investigation around Java 9 in Google. If everything works for us after applying this patch I'll probably cut 1.1.8.

[benoitf]

hello @ekuefler, have you made any progress on the tests with java9 ? Because I'm interested in having a release integrating thix PR's fix. Thanks

[ekuefler]

Sorry for the delay. 1.1.8 is in maven central now with this change: http://repo1.maven.org/maven2/com/google/gwt/gwtmockito/gwtmockito/1.1.8/. I'm still doing some verifications before I update the readme, but you should be able to use it now.