google / haskell-trainings

Haskell 101 and 102: slides and codelabs
Apache License 2.0
1.38k stars 110 forks source link

A branch in my name #11

Open nicuveo opened 5 years ago

nicuveo commented 5 years ago

I am planning to keep working on this material, but in my own way. I do not agree with all the changes that have been made in master, far from it. If someone were to create a branch with my name, based on v1.0, I could start submitting PRs with my modifications.

ilya-bobyr commented 5 years ago

Sorry I did not reply earlier. Do you want it to be called just "nicuveo"?

Consider that if you want the content to be completely different, then, maybe it is worth stroing it in a separate repository? Then you would have full control. Someone will still have to aprove your PRs for this repository.

So far the changes you have published are quite minor. But two of them remove references to Google - one removes it from the comment and the other removes the logo. Wouldn't we want to keep the logo? This repository is the Google haskell training, after all.

Also, maybe we can discuss which changes you like and which you do not like. It might be more productive to work together, than completely separately.