google / haskell-trainings

Haskell 101 and 102: slides and codelabs
Apache License 2.0
1.38k stars 110 forks source link

Add docker for easy environment set up #17

Closed shaneikennedy closed 5 years ago

shaneikennedy commented 5 years ago

👋 Loved the video for haskell 101, thanks!

I wanted to get started right away and unfortunately found that it wasn't very straightforward getting my environment setup to start doing the examples and running tests on macOS, so I setup a quick docker environment.

With this I can still code on my machine and build/run with docker-compose up --build

Figured I would offer this up in case others may find it useful.

If this sounds useful let me know if there's anything else you'd want to make this more complete, docs etc...

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹī¸ Googlers: Go here for more info.

shaneikennedy commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to [go/cla#troubleshoot](http://go/cla#troubleshoot) ([Public version](https://opensource.google.com/docs/cla/#troubleshoot)).

* The email used to register you as an authorized contributor must be the email used for the Git commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).

* The email used to register you as an authorized contributor must also be [attached to your GitHub account](https://github.com/settings/emails).

ℹī¸ Googlers: Go here for more info.

@googlebot I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹī¸ Googlers: Go here for more info.

ilya-bobyr commented 5 years ago

I think this could be useful. We occasionally see people have issues with macOS, especially older versions.

@mihaimaruseac What do you think?

It would be helpful to have some basic instructions on how to use it. Maybe something like a transcript of a successful run, so that one can copy/paste the commands and start working on the codelab.

ilya-bobyr commented 5 years ago

Thanks for the change! Consider doing the same for 102 - it would be nice to be consistent.

shaneikennedy commented 5 years ago

@ilya-bobyr sure thing, just making my way through the codelabs so I will make a PR when i get to 102 👍