Replace matching for number with enum_primitive::FromPrimitive

matthiasbeyer commented 7 years ago

Small improvement I guess.

I do not have a powerful enough machine to test this, so I hope your CI can do the job for me. :smile:

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

matthiasbeyer commented 7 years ago

As it seems, I need a google account to contribute code to this repository. I do not have one and I do not want to create one just for this contribution (or at all), so I'll close this PR. :cry:

brinchj commented 7 years ago

Thanks for the pull-request. Unfortunately, there is nothing I can do about the CLA signing requiring a Google account. But I do appreciate your effort here.

If you are unable to sign the CLA, do feel free to contribute to the project in non-coding ways, like filing a but or similar. All interaction is of course appreciated, but I also understand that it is disappointing to get blocked.

Thanks for the effort and attention! :+1:

google / hat-backup

Replace matching for number with enum_primitive::FromPrimitive #85