Generealize SameOperandsAndResultRings to work for multiple dialects

google / heir

A compiler for homomorphic encryption

https://heir.dev/

Apache License 2.0

285 stars 40 forks source link

Closed j2kun closed 5 months ago

j2kun commented 10 months ago

SameOperandsAndResultRings is useful for BFV/CKKS as well, and so we should generalize the trait. My idea is as follows:

Add a type (or op?) interface that says "this type/op has rings associated with it"
Make it somehow easy for a dialect to specialize this to its particular types/ops
Rewrite SameOperandsAndResultRings in terms of the interface and put it in include/Dialect/CommonTraits.td.

github-actions[bot] commented 5 months ago

This issue has 1 outstanding TODOs:

This comment was autogenerated by todo-backlinks