google / heir

A compiler for homomorphic encryption
https://heir.dev/
Apache License 2.0
318 stars 47 forks source link

tfhe_rust: improve generality of e2e test runner #235

Open j2kun opened 11 months ago

j2kun commented 11 months ago
j2kun commented 11 months ago

Variadic args seems hard in rust because rust doesn't have a splat operator to read in the variadic CLI arguments and convert them to a static function signature. I thought maybe macro_rules would provide a workaround, but didn't have the time to figure it out.

j2kun commented 11 months ago

A colleague pointed me to this which might help support the variadic arguments issue: https://jsdw.me/posts/rust-fn-traits/

See the section "Accepting variable arity functions using Trait Families"

github-actions[bot] commented 9 months ago

This issue has 4 outstanding TODOs:

This comment was autogenerated by todo-backlinks

j2kun commented 8 months ago

Now that I've got the openfhe e2e tests working, it seems reasonable to migrate to proper rust rules and a rust test harness instead of lit testing.