Determine if `AlignRotations` pattern needs more complex patterns

google / heir

A compiler for homomorphic encryption

https://heir.dev/

Apache License 2.0

309 stars 46 forks source link

Determine if `AlignRotations` pattern needs more complex patterns #514

Open j2kun opened 6 months ago

j2kun commented 6 months ago

Currently it matches against (OpA (rotate...) (OpB (rotate...) (rotate...))) and (OpA (OpB (rotate...) (rotate...)) (rotate...)), should it also handle (OpA (OpB (rotate...) (rotate...)) (OpC (rotate...) (rotate...)))

github-actions[bot] commented 6 months ago

This issue has 1 outstanding TODOs:

lib/Dialect/TensorExt/Transforms/InsertRotate.td:91: handle OuterOp with two different InnerOps on the LHS and RHS

This comment was autogenerated by todo-backlinks

j2kun commented 6 months ago

Part of https://github.com/google/heir/issues/475