Determine if nested `AlignRotations` patterns are still necessary

google / heir

A compiler for homomorphic encryption

https://heir.dev/

Apache License 2.0

350 stars 50 forks source link

Determine if nested `AlignRotations` patterns are still necessary #579

Open j2kun opened 8 months ago

j2kun commented 8 months ago

While debugging https://github.com/google/heir/issues/578, it seemed to me that the buggy pattern AlignRotations_RightAssociated_Inner_#InnerOp#_Outer_#OuterOp (and its related LeftAssociated version) are not doing anything. It seems like they are no-ops, but we might want to determine if they are still providing any value, and remove them if not.

github-actions[bot] commented 7 months ago

This issue has 1 outstanding TODOs:

lib/Dialect/TensorExt/Transforms/InsertRotate.td:147: determine if these patterns are still necessary after the

This comment was autogenerated by todo-backlinks