search

google / horologist

Horologist is a group of libraries that aim to supplement Wear OS developers with features that are commonly required by developers but not yet available.
https://google.github.io/horologist/
Apache License 2.0
543 stars 87 forks source link

Tile "Bitmap.toImageResource()" enforce RGB_565 without possibility to change and keep alpha. #2253

Closed Tolriq closed 3 weeks ago

Tolriq commented 3 weeks ago

In accompanist Tile Bitmap.toImageResource() enforce RGB_565, took me quite some time to find that one, this force a black background on the image that are round cropped (.transformations(CircleCropTransformation()) ) and of course as I did test with very dark images, I did not see the crop working and black background and searched around the source image.

image

The configuration should probably be a parameter as the doc is easy to miss and not very clear about why it's enforced.

yschimke commented 3 weeks ago

I think dupe of https://github.com/google/horologist/issues/251

Valid request. Care to submit a PR, or otherwise review and test for me if not?

yschimke commented 3 weeks ago

Let's continue on that other PR.