google / horologist

Horologist is a group of libraries that aim to supplement Wear OS developers with features that are commonly required by developers but not yet available.
https://google.github.io/horologist/
Apache License 2.0
575 stars 95 forks source link

Use Roborazzi A11y checks #2463

Closed yschimke closed 6 days ago

yschimke commented 6 days ago

WHAT

This change updates the handling of accessibility checks for off-screen elements in the UI tests. It suppresses accessibility errors for elements which are off-screen but are intended to be scrolled on-screen.

This improves the accuracy and efficiency of the accessibility tests by ignoring false-positives related to these elements.

Additionally, it removes unnecessary custom shadow classes that were previously used for accessibility testing. These shadows caused conflicts and were replaced by existing Roborazzi features. This simplifies the testing setup and relies on external libraries for better maintainability.

Finally, it updates the version of the Roborazzi library to bring in the new accessibility checking capabilities. This allows the tests to use newer, more robust and accurate accessibility checking features.

WHY

HOW

Checklist :clipboard:

yschimke commented 6 days ago

View with bounds: [24,438][430,542]: This clickable item's speakable text: "Playlists" is identical to that of 1 other item(s). Reported by com.google.android.apps.common.testing.accessibility.framework.checks.DuplicateSpeakableTextCheck

image

yschimke commented 6 days ago

@garanj landing as test only, will follow up on review comments.