search

google / identity-toolkit-java-client

Google Identity Toolkit client library for Java
Apache License 2.0
37 stars 27 forks source link

added proxy capability to the client #27

Closed Erni closed 8 years ago

Erni commented 8 years ago

Identity client doesn´t allow the user to use the library behind a proxy. This does not happen in libraries like the Java client for Google sign-in in which you can set the proxy via NetHttpTransport. Therefore it would be really usefull to merge this branch in which you can set your proxy with: Proxy proxy = new Proxy(Proxy.Type.HTTP, new InetSocketAddress(host, port)); GitkitClient gitkitClient = GitkitClient.createFromJson("conf/gitkit-server-config.json",proxy);

liujin-google commented 8 years ago

Thanks for the pull request Erni. Yes, proxy support is a useful feature. Just a couple of trivial comments.

Erni commented 8 years ago

Refactored as you suggested so it is consistent with the existing style :)

liujin-google commented 8 years ago

Almost there - just some formatting comments.

Erni commented 8 years ago

Done! Anything else? :)

liujin-google commented 8 years ago

Thanks a lot Erni!

Erni commented 8 years ago

It´s been a pleasure contributing to a Google library :)