Closed Erni closed 8 years ago
Thanks for the pull request Erni. Yes, proxy support is a useful feature. Just a couple of trivial comments.
Refactored as you suggested so it is consistent with the existing style :)
Almost there - just some formatting comments.
Done! Anything else? :)
Thanks a lot Erni!
It´s been a pleasure contributing to a Google library :)
Identity client doesn´t allow the user to use the library behind a proxy. This does not happen in libraries like the Java client for Google sign-in in which you can set the proxy via NetHttpTransport. Therefore it would be really usefull to merge this branch in which you can set your proxy with:
Proxy proxy = new Proxy(Proxy.Type.HTTP, new InetSocketAddress(host, port));
GitkitClient gitkitClient = GitkitClient.createFromJson("conf/gitkit-server-config.json",proxy);