google / identity-toolkit-java-client

Google Identity Toolkit client library for Java
Apache License 2.0
37 stars 27 forks source link

Changed tomcat-servlet-api to provided scope and removed redundant compile scope def #32

Closed acwwat closed 8 years ago

acwwat commented 8 years ago

identity-toolkit-java-client is used in a web container environment which should already provide the servlet API, so the scope for tomcat-servlet-api can be set to provided instead to avoid being pulled in as an extra packaging dependency.

Also removed the compile scope definitions from dependencies as not specifying a scope already implies a compile scope.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


acwwat commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

liujin-google commented 8 years ago

Thanks for the contribution Anthony!