search

google / incremental-dom

An in-place DOM diffing library
http://google.github.io/incremental-dom/
Apache License 2.0
3.54k stars 180 forks source link

Initial TypeScript migration #353

Closed iteriani closed 6 years ago

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

iteriani commented 6 years ago

Check

googlebot commented 6 years ago

CLAs look good, thanks!

eduardolundgren commented 6 years ago

For the context, would you mind describing what was the main reason to move all code-base to TypeScript?

iteriani commented 6 years ago

Mostly this is so the code within Google internally is easier to sync with the repo.