google / incremental-dom

An in-place DOM diffing library
http://google.github.io/incremental-dom/
Apache License 2.0
3.53k stars 178 forks source link

Only call assertPatchOuterHasParentNode() if the node has a key #466

Closed SLaks closed 3 years ago

SLaks commented 3 years ago

This fixes false positives that produce warning spam.

This is especially annoying for attributes templates, which can be stringified via patchOuter().

I believe this is the correct check.

SLaks commented 3 years ago

This fixes internal issue b/189132201