google / incremental-dom

An in-place DOM diffing library
http://google.github.io/incremental-dom/
Apache License 2.0
3.54k stars 180 forks source link

Fix unit tests on macOS. #475

Closed emspishak closed 2 years ago

emspishak commented 2 years ago

This disables Chrome's sandbox when the test in run on macOS.

It's unclear why this is necessary, but it does fix the test. https://gist.github.com/mattem/f6e85437b0dbcca661013a19247889a9#file-karma-conf-js-L49 does something similar. The error in Chrome's logs is "SeatbeltExecServer: Failed to initialize sandbox: -1 Operation not permitted". I couldn't get any more details about the failure or find any details about it online. I don't think sandboxing should matter for these tests though, since it's a security feature.