google / intellij-gn-plugin

BSD 3-Clause "New" or "Revised" License
14 stars 11 forks source link

Add 221.* IDE compatibility #20

Closed bc-lee closed 2 years ago

bc-lee commented 2 years ago

I didn't update any other dependencies, and I just modified this as shown here and tried to build. And I've been using this on CLion 2022.1 for a few days. So far, it works as expected.

brunowonka commented 2 years ago

Thanks for the PR. I haven't been able to put time on this lately, especially because I've stopped using IntelliJ IDEs myself for my day to day work. I'll try my best to rev a new release with this this week.

bc-lee commented 2 years ago

Oh I see. I'm thinking about creating a fork and maintaining it.

By the way, can you tell me which IDE you are currently using? VS Code?

brunowonka commented 2 years ago

I've been using VS Code, I work on Fuchsia and most of our tooling has gained more official VS Code support (though we don't have a good GN plugin yet 😛).

If you're interested in maintaining, I can go through the motions of deprecating the repo and perhaps giving you ownership of the plugin with Jetbrains so users wouldn't have to re-download.

tamird commented 2 years ago

@brunowonka you could also give @bc-lee the commit bit on this repo, though I'm not sure what the Google policy on this is.

brunowonka commented 2 years ago

Yeah I'm looking into the policy and reaching out to the powers that be, I'll keep this updated.

brunowonka commented 2 years ago

Okay looks like it's fine for us to keep this repo. @bc-lee I think the biggest thing we want here is for you to be able to publish updates to the plugin. We should try it out with this release. Do you have a JB marketplace account so I can give you permissions on the plugin? If you want to discuss this with larger bandwidth perhaps look for us in the Fuchsia discord (I'm always hanging in the #networking and #netstack3 channels, just gimme a shout)

bc-lee commented 2 years ago

If I get maintainer rights to this GitHub repository and I can upload the plugin to JB Marketplace, then everything will be OK, and I'll maintain this repository. My JB Marketplace account is here: https://plugins.jetbrains.com/author/0dfc1c7f-fffa-4dfc-bf4b-7bc8e5a55599

brunowonka commented 2 years ago

changes lgtm, @bc-lee should have write access and hopefully upload access on the JB plugin now. Please check if you can enter the plugin admin page and then merge here and upload new version to try the workflow. And thanks for volunteering :)

bc-lee commented 2 years ago

Thank you for allowing me to upload the plugin. Also, thanks for the original work. After building the plugin locally, I successfully uploaded it to JB Marketplace.

Screen Shot 2022-05-12 at 7 13 53