search

google / ion

Ion
Apache License 2.0
1.43k stars 92 forks source link

Use references when joining threads in KillAllThreads #7

Closed dlrobertson closed 8 years ago

dlrobertson commented 8 years ago

Super super small change. It might be nice to use const references when iterating through threads_ and joining by thread_id in WorkerPool::KillAllThreads. thread_id will be copied by port::JoinThread.

Review on Reviewable

oon3m0oo commented 8 years ago

This is done in the latest push. Thanks!