search

google / ioweb2015

I/O Web App 2015
https://events.google.com/io2015/
Apache License 2.0
687 stars 122 forks source link

Fixes #1444. Adds a server proxy for picasa api calls #1445

Closed ebidel closed 9 years ago

ebidel commented 9 years ago

R: @crhym3 @jeffposnick

I wrote some go!

@jeffposnick you're already caching all requests to api/*. Is this the only change I need to make for SW?

x1ddos commented 9 years ago

yo, I think you wrote the perfect go code. well done!

ebidel commented 9 years ago

PTAL

ebidel commented 9 years ago

I wont merge this into phase 2. Phase 3 is imminent.

x1ddos commented 9 years ago

LGTM! I'll add some caching once this is in.

jeffposnick commented 9 years ago

Re: the SW question, https://github.com/GoogleChrome/ioweb2015/blob/master/app/scripts/shed/cache-then-network.js#L44 will handle networkFirst-caching, so you should be fine.