search

google / ioweb2015

I/O Web App 2015
https://events.google.com/io2015/
Apache License 2.0
686 stars 122 forks source link

Adding some tests to IOWA.Router #1503

Closed devnook closed 9 years ago

devnook commented 9 years ago

R: @ebidel @crhym3 all

x1ddos commented 9 years ago

Thanks for doing this. Let me see if we can run it on ci as well....

x1ddos commented 9 years ago

Reviewed

devnook commented 9 years ago

I'm not convinced one project should force you to install a stack globally if it is not really needed for that project. I'd rather let developer decide on their own if they want to have wct installed globally, if they intend to use it with other polymer projects (which otherwise they might never have, e.g. if they just want to check out iowa sw offline stuff).

I can move it to use global wct (in README), but then the task won't be accessible in gulp (not a big deal I guess).

x1ddos commented 9 years ago

well, if someone just wants to check it out, putting wct in package.json is worse becase they will be installing it for nothing. those who want to develop can either install it locally or globally, whatever the preference is.

yeah, the gulp task is just one line. we can add it to our gulpfile manually.

x1ddos commented 9 years ago

LGTM I'll soon add this to the CI build too.