search

google / ioweb2015

I/O Web App 2015
https://events.google.com/io2015/
Apache License 2.0
686 stars 122 forks source link

[Experiment] visualizers in front of keyboard instrument #1506

Closed monicabagagem closed 9 years ago

monicabagagem commented 9 years ago

This is due to the featured sessions on the homepage - this looks quite bad as it's covering an entire instrument.

What are our options to fix/improve?

screen shot 2015-05-29 at 8 18 16 pm

ebidel commented 9 years ago

@tdreyno and I chatted about a similar issue in https://github.com/GoogleChrome/ioweb2015/issues/1088#issuecomment-94905960. The intention is that the experiment fully takes over the page as-is. We've changed the layout quite a bit since first designed. The experiment is doing what it is supposed to, but the layout looks less awesome than it used it.

monicabagagem commented 9 years ago

Is there any possible fix since this is the version that will stay up for prosperity? :)

ebidel commented 9 years ago

It's working as intended. I think we'd have to change the design of the page

monicabagagem commented 9 years ago

Is there a way to just remove the 3 visualizers from the Experiment, without affecting the layout of the homepage?

I know it's working as intended right now - just trying to think of possible ways to improve the experience since it's not optimal as it is. I'm sure Instrument doesn't want this to be the final version either!

Do you have any further ideas on your end?

tdreyno commented 9 years ago

You could omit the class which enables the experiment on that container... but, I'd actually rather keep the conceptual purity of this version.

You can click through the visualizers to access the instrument, so it's not nearly as awkward as it looks.

That said, maybe we can stub out an optimal page that could live at /experiment. But, I don't want to create more work when this is all done and everyone already loves it :)

ebidel commented 9 years ago

Thomas is there a way to hide the card visualizers? At least that way we could make the main instrument prominent and not covered up for this one.

On Mon, Jun 1, 2015, 7:38 AM Thomas Reynolds notifications@github.com wrote:

You could omit the class which enables the experiment on that container... but, I'd actually rather keep the conceptual purity of this version.

You can click through the visualizers to access the instrument, so it's not nearly as awkward as it looks.

That said, maybe we can stub out an optimal page that could live at /experiment. But, I don't want to create more work when this is all done and everyone already loves it :)

— Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/ioweb2015/issues/1506#issuecomment-107650314 .

tdreyno commented 9 years ago

Try omitting the visualizer class on them. That should keep the experiment from trying to render its version.