search

google / ioweb2015

I/O Web App 2015
https://events.google.com/io2015/
Apache License 2.0
686 stars 122 forks source link

Schedule: page content doesnt slide in on page nav #1521

Closed ebidel closed 9 years ago

ebidel commented 9 years ago

https://github.com/GoogleChrome/ioweb2015/commit/d2ec7f1a86123483acd1d07fb2c7f84f2413b195 added support for es6-promise 2.3.0. However, it seems 2.1+ doesnt resolve promises correctly. Navigating from /about -> /schedule does not finish the slide up animation of the schedule.

It's also weird this is affecting Chrome (native Promises)

ebidel commented 9 years ago

Doesn't look like this is the culprit. I went back commit time to before the router tests were added, and this did no good.

There was an error being thrown in the animation promise chain that I fixed in https://github.com/GoogleChrome/ioweb2015/commit/6f21401b361bbd0d2d5c687d23da230ea1e4826f. However, the schedule page is still affected by something. Navigating to it does not slide up the content.

@devnook would you mind taking a look? Why would the schedule page be the only one not to slide in?

monicabagagem commented 9 years ago

Do we have any leads on this bug and when we expect a fix, since other bugs are dependant on this one to be pushed live?

devnook commented 9 years ago

The content slides in, but is well below the fold. Probably some css issue, I'm investigating.

ebidel commented 9 years ago

Deployed