search

google / ioweb2016

I/O web app 2016
https://events.google.com/io2016
Apache License 2.0
517 stars 87 forks source link

Featured Session cards don't show their background images #1008

Closed jungkees closed 8 years ago

jungkees commented 8 years ago

Scenario:

  1. Load https://events.google.com/io2016/
  2. Scroll down to "Featured Session" area

Tested on:

Expected behavior:

Actual behavior:

In the "Elements" tab of the devtools, I found the following style attribute of the card-content div element in "io-home-page.html" is not applied: style="height:100%; background-image:url([[_computeBgImage(item)]])"

ebidel commented 8 years ago

Those versions of chrome are fairly old. Can you confirm this is working on newer browsers?

On Mon, May 23, 2016, 1:52 AM Jungkee Song notifications@github.com wrote:

Scenario:

  1. Load https://events.google.com/io2016/
  2. Scroll down to "Featured Session" area

Tested on:

  • Samsung Internet 4.0 (Chromium 44.0.2403.133)
  • Chrome 43.0.2357.93

Expected behavior:

  • "Featured Session" cards render with their background images

Actual behavior:

  • "Featured Session" cards don't show any background images

In the "Elements" tab of the devtools, I found the following style attribute of the card-content div element in "io-home-page.html" is not applied: style="height:100%; background-image:url([[_computeBgImage(item)]])"

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/ioweb2016/issues/1008

ebidel commented 8 years ago

Fixed via https://github.com/GoogleChrome/ioweb2016/commit/e9a6c4c216949ca6d484cfa08b6e802aa06ae339

jungkees commented 8 years ago

Thanks for the quick update!