Send push messages as appropriate

google / ioweb2016

I/O web app 2016

https://events.google.com/io2016

Apache License 2.0

517 stars 87 forks source link

Send push messages as appropriate #932

Closed wibblymat closed 8 years ago

wibblymat commented 8 years ago

@crhym3 @ebidel @nicolasgarnier @pengying @GoogleChrome/ioweb-core

Not currently sending updated session information along with the messages. It turns out that the session data is too big, and causes the sending to fail :/

Will try to resolve in a follow up

Will add tests over the weekend, but wanted to get this in front of people ASAP.

ebidel commented 8 years ago

@crhym3 for the Go bits.

x1ddos commented 8 years ago

Reviewed.

ebidel commented 8 years ago

@wibblymat can you ping when this is ready to review again?

wibblymat commented 8 years ago

Ping @ebidel @crhym3

x1ddos commented 8 years ago

Tests?

wibblymat commented 8 years ago

@crhym3 tests are proving (like everything else here) to be harder to do than anticipated. I'm working on it, but I'm also working on other things :(

@ebidel, @crhym3 are we happy enough to put this on staging for some manual testing? First notification (IO is starting soon!) is actually due to go out at 10am tomorrow.

ebidel commented 8 years ago

Yea, let's file a bug for tests. We need to land this.