Fixes #922. Use real buttons for add/remove icons. Fix busted paper-fab

google / ioweb2016

I/O web app 2016

https://events.google.com/io2016

Apache License 2.0

518 stars 87 forks source link

Fixes #922. Use real buttons for add/remove icons. Fix busted paper-fab #933

Closed robdodson closed 8 years ago

robdodson commented 8 years ago

Uses <button> for add/remove toggles so we get click handling for free. Use the platform!
Changed session detail handler to click instead of up as it wasn't firing for the keyboard
Made paper-fabs hover when keyboard focused

@ebidel PTAL

ebidel commented 8 years ago

Looks good. I get this when I tab to the fab in canary:

robdodson commented 8 years ago

That looks like the back to top fab. My current version isn't showing it anymore, do I need to jump to a future date?

robdodson commented 8 years ago

ah I see it's on the extended page. Awesome that it doesn't do that on Beta :\

robdodson commented 8 years ago

It's because the fab is wrapped in an <a>. https://github.com/GoogleChrome/ioweb2016/blob/master/app/scripts/helper/elements.js#L216-L239

It's the <a> that's being focused there (and I guess clipping in canary). Do you want me to remove the anchor and move those behaviors to fab itself?

ebidel commented 8 years ago

No, we should keep the anchor. Otherwise we have to create our own fab. Just wanted to be sure you were aware of it.

robdodson commented 8 years ago

Otherwise we have to create our own fab.

Not sure what you mean? There's a fab there as well, it's just wrapped.