search

google / ioweb2016

I/O web app 2016
https://events.google.com/io2016
Apache License 2.0
518 stars 87 forks source link

backend: multiple twitter accounts in social feed #934

Closed x1ddos closed 8 years ago

x1ddos commented 8 years ago

This will also shard cached copy across multiple instances, like we already do with schedule data, to support higher QPS.

Closes #757

@wibblymat @ebidel

x1ddos commented 8 years ago

Submitting TBR - would like to have it running on staging.

ebidel commented 8 years ago

Please don't merge big new features like this with reviews. Social shows up in a few places on the site and if it doesn't work, we're hosed.

x1ddos commented 8 years ago
ebidel commented 8 years ago

Bug fixes are different than changing how social works across the site. People are also embedding the widget and it might need to be updated now. Haven't looked yet.

Anyways not a big deal. Just wish stuff like this could have landed weeks ago instead of the day before a launch :/

On Sun, May 15, 2016, 11:24 AM alex notifications@github.com wrote:

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/ioweb2016/pull/934#issuecomment-219301934

x1ddos commented 8 years ago

Bug fixes can introduce as much regression.

I wish the whole planning was done a way ahead of time :( Didn't like how it went this year at all.

On 15 May 2016 at 21:15, Eric Bidelman notifications@github.com wrote:

Bug fixes are different than changing how social works across the site. People are also embedding the widget and it might need to be updated now. Haven't looked yet.

Anyways not a big deal. Just wish stuff like this could have landed weeks ago instead of the day before a launch :/

On Sun, May 15, 2016, 11:24 AM alex notifications@github.com wrote:

  • I was confident enough this won't introduce backward incompatibilities with the frontend
  • this is not deployed on prod automatically
  • needed to test this manually on staging
  • I'm not alone:

https://github.com/GoogleChrome/ioweb2016/pulls?q=is%3Apr+is%3Aclosed+tbr

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub < https://github.com/GoogleChrome/ioweb2016/pull/934#issuecomment-219301934>

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/ioweb2016/pull/934#issuecomment-219307947

ebidel commented 8 years ago

Looks good.

I'm not seeing https://twitter.com/sundarpichai/status/686963501219233792 in staging (https://io-webapp-staging.appspot.com/io2016/api/v1/social) though. That should show up right? The other accounts only have #io16 retweets, which we don't include.

x1ddos commented 8 years ago

That was 5 months ago. Twitter returns at most 200 tweets per account, including retweets even if we don't request them. Most likely Sundar has had more that 200 tweets + retweets since then, or Twitter returns less than 200 tweets for his account.

On 15 May 2016 at 23:29, Eric Bidelman notifications@github.com wrote:

Looks good.

I'm not seeing https://twitter.com/sundarpichai/status/686963501219233792 in staging (https://io-webapp-staging.appspot.com/io2016/api/v1/social) though. That should show up right? The other accounts only have #io16 retweets, which we don't include.

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/ioweb2016/pull/934#issuecomment-219314861