Mostly Speed up - Githubissues

google / ipaddr-py

Google's Python IP address manipulation library

Apache License 2.0

195 stars 70 forks source link

Open nouiz opened 9 years ago

nouiz commented 9 years ago

DO NOT MERGE YET.

I got by email some fix to this code that I added in my repo in a commit. The change is one line. I'm contacting the author of that fix.

If I don't get an answer, I think that I could tell you which method it is and you could try to fix it?

fix gh-99

nouiz commented 9 years ago

I added the fix. I got an confirmation that it is ok.

shields commented 9 years ago

Our lawyers won't let me merge the other person's change, even a single-line change, unless they also accept the CLA. I'm sorry; it is annoying.

Maybe it's best if you tell me about that change and I write the one line.

nouiz commented 9 years ago

The method __contains__ of the class _BaseNet don,t always return the good answer. It probably miss tests.