Open vjay82 opened 3 years ago
See #9
We welcome patches, especially for Windows since none the current contributors (myself including) develop on Windows. For this case where the command line to zip is to long it could be changed to use -@ and pass the arguments on stdin.
The relevant code is here: https://github.com/google/j2cl/blob/fd4de17f4afab9a38f72b66786c5795712d4978a/jre/java/package_sources.bzl#L22-L37
The arguments could be converted to a file arg instead as well. However when you pass this you may just hit another problem.
The community developed maven plugin works on Windows (without WSL), and also has features the bazel plugin does not, such as testing and iterative-development source maps.
I've also submitted a PR for a live-reloading dev server. So soon it will get even better!
I must say that while I'm a big fan of J2CL, I absolutely and passionately hate bazel. But that is a bikeshed not productive to discuss.
Off topic: @AugustNagro Thank you very much. Had to remove 3 test-subprojects from the plugin to have it building successfully but it did after that, even your "mvn j2cl:watch" works perfectly. Had to implement this feature myself back when using the GWT transpiler. You absolutely made my day sir. First you solved my build issue and second my headache, which I got by thinking about on how to explain all those nasty new dependencies to my colleagues. Maven->Plugin->there you go. Platform independent, lean and clean. Thank you, big thumbs up!
@tbroyer I want to start contributing to this project. Can you please guide me a bit. Thanks a lot
Hello,
I tried following your getting started under https://github.com/google/j2cl/blob/master/docs/getting-started.md The following happens on my machine (Windows (sadly)). Installing bazelisk through npm or chocolatey does not result in any different outcome.
Using WSL2:
If using MSYS2:
My suspicion is that in both cases you are trying to put lots of stuff on a command line and that on Windows the maximum is less than under Linux or macOS. As Windows is probably pretty rare, I hit this bug. Sooner or later it may hit anyone. Putting long list of files on a command line is not very reliable.
Regards