Add support for the user passing through defs attribute into j2cl_application

google / j2cl

Java to Closure JavaScript transpiler

Apache License 2.0

1.23k stars 144 forks source link

Add support for the user passing through defs attribute into j2cl_application #127

Closed realityforge closed 3 years ago

realityforge commented 3 years ago

The motivation for this change is to pass through --env=CUSTOM to the closure compiler and this change seems to achieve this but I am completely unfamiliar with skylark so there may be much better ways of doing this...

gkdn commented 3 years ago

Externs are only relevant optimized output (i.e. production) and you can already pass them with extra_production_args. Doesn't that work for you?

realityforge commented 3 years ago

That works fine - thanks!