search

google / j2cl

Java to Closure JavaScript transpiler
Apache License 2.0
1.23k stars 144 forks source link

Add support for Math.IEEEremainder #142

Open dasa opened 2 years ago

dasa commented 2 years ago

Is your feature request related to a problem? Please describe.

Math.IEEEremainder isn't implemented and is commented as such at: https://github.com/google/j2cl/blob/master/jre/java/java/lang/Math.java#L34

Describe the solution you'd like

Add support for Math.IEEEremainder

Describe alternatives you've considered

I attempted an implementation based on this doc:

    static private double IEEEremainder(double dividend, double divisor) {
        return dividend - (divisor * Math.round(dividend / divisor));
    }

Additional context

The link above shows expected output, and there are tests for the Kotlin implementation.

gkdn commented 2 years ago

Thanks for the detailed report. Would you like to send a PR?