search

google / j2cl

Java to Closure JavaScript transpiler
Apache License 2.0
1.22k stars 143 forks source link

Wasm sample broken v2 #195

Closed treblereel closed 1 year ago

treblereel commented 1 year ago

It looks like commit f8b561bf1f04d9c79a5dc1aca6d2dbfc0635a46f broke the wasm sample.

To Reproduce 1) ./build_test.sh 2) bazel build //samples/wasm/src/main/java/com/google/j2cl/samples/wasm:app

... with the error message:

ERROR: /Users/treblereel/workspace/temp/j2cl/samples/wasm/src/main/java/com/google/j2cl/samples/wasm/BUILD:41:19: Compiling to Wasm (stage 1) failed: (Exit 1): binaryen failed: error executing command bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/third_party/binaryen --enable-exception-handling --enable-gc --enable-reference-types --enable-sign-ext --enable-strings --enable-nontrapping-float-to-int ... (remaining 12 arguments skipped)
[parse exception: expected integer (at 51759:244)]
rluble commented 1 year ago

Could try with an updated version of binaryen (possibly have to build binaryen from source).

treblereel commented 1 year ago

@rluble thanks, it works with:

wasm-opt version 112 (version_112-170-gee738ac1f)