Add Java 11 Optional.isEmpty()

google / j2cl

Java to Closure JavaScript transpiler

Apache License 2.0

1.25k stars 146 forks source link

Add Java 11 Optional.isEmpty() #226

Closed treblereel closed 9 months ago

treblereel commented 9 months ago

(cherry picked from commit d73d095eabcf18d565ee9eebacdaa2895ae77c52)

@gkdn

I have enabled com.google.j2cl.jre.java8.util.OptionalTest.testIsEmpty() coz j2cl is now support java11
I also moved tests (Optional(Long/Int/Double) from java11 package to java8 to follow the same pattern as OptionalTest.testIsEmpty()

Please let me know if it's ok.

gkdn commented 9 months ago

Thanks that looks ok. If we introduce a completely new API, we can use the new java9 tests; but if the API is already there and tested, we can reuse the earlier java tests. (I will merge all of them at one point after dust settles down)