Fix guava sample WORKSPACE file

emilieroberts commented 4 months ago

The WORKSPACE file in the guava sample incorrectly builds the Hello World sample. Update the file to correctly build the guava project.

TEST:

bazel build src/main/java/com/google/j2cl/samples/guava:guava
bazel build src/main/java/com/google/j2cl/samples/guava:guava-dev-server
navigate to http://localhost:6006/guava_dev.html

niloc132 commented 4 months ago

CI failure is from a stream of "no space left on device" errors, related to running wasm sample test:

...
ERROR: /home/runner/.cache/bazel/_bazel_runner/aa8340a5ae74caf8627fabe9e1eba417/external/io_bazel_rules_go/BUILD.bazel:42:7: GoStdlib external/io_bazel_rules_go/stdlib_/pkg failed: (Exit 1): builder failed: error executing command 
  (cd /home/runner/.cache/bazel/_bazel_runner/aa8340a5ae74caf8627fabe9e1eba417/execroot/com_google_j2cl_samples_helloworld && \
  exec env - \
    CC=/usr/bin/gcc \
    CGO_CFLAGS='-U_FORTIFY_SOURCE -fstack-protector -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -O2 -D_FORTIFY_SOURCE=1 -DNDEBUG -ffunction-sections -fdata-sections -fno-canonical-system-headers -Wno-builtin-macro-redefined -D__DATE__="redacted" -D__TIMESTAMP__="redacted" -D__TIME__="redacted"' \
    CGO_ENABLED=1 \
    CGO_LDFLAGS='-fuse-ld=gold -Wl,-no-as-needed -Wl,-z,relro,-z,now -B/usr/bin -pass-exit-codes -lm' \
    GOARCH=amd64 \
    GOEXPERIMENT=nocoverageredesign \
    GOOS=linux \
    GOPATH='' \
    GOROOT=external/go_sdk \
    GOROOT_FINAL=GOROOT \
    PATH=/usr/bin:/bin \
  bazel-out/k8-opt-exec-2B5CBBC6-ST-b33d65c724e6/bin/external/go_sdk/builder_reset/builder stdlib -sdk external/go_sdk -installsuffix linux_amd64 -out bazel-out/k8-opt-exec-2B5CBBC6-ST-b33d65c724e6/bin/external/io_bazel_rules_go/stdlib_ -package std -package runtime/cgo -gcflags '')
# Configuration: 7b23d2d846d17f16d8fafc93c76d0fec9c4a898c506081349aea39a2ae3b6b6b
# Execution platform: @local_config_platform//:host
encoding/ascii85: write /tmp/go-build3642503264/b133/importcfg: no space left on device
encoding/base32: mkdir /tmp/go-build3642503264/b134/: no space left on device
encoding/csv: mkdir /tmp/go-build3642503264/b135/: no space left on device
encoding/gob: mkdir /tmp/go-build3642503264/b136/: no space left on device
encoding/json: mkdir /tmp/go-build3642503264/b137/: no space left on device
# debug/gosym
compile: writing output: write $WORK/b131/_pkg_.a: no space left on device
encoding/xml: mkdir /tmp/go-build3642503264/b138/: no space left on device
log: mkdir /tmp/go-build3642503264/b140/: no space left on device
...

treblereel commented 4 months ago

@niloc132 the same in my pr

gkdn commented 4 months ago

Thanks @emilieroberts. Will update (though normally shouldn't have any impact other than being confusing)

@niloc132 @treblereel For some reason the Github's cache eviction has stopped working properly (or more likely wasn't already working properly and they decided to enforce quotas more strictly). I couldn't find anything useful when I searched about it.

google / j2cl

Fix guava sample WORKSPACE file #241