search

google / j2cl

Java to Closure JavaScript transpiler
Apache License 2.0
1.22k stars 143 forks source link

bump jdt to 4.22 #243

Open treblereel opened 1 month ago

treblereel commented 1 month ago

It seems safe (at least, I hope so) to upgrade the JDT to version 4.22. The updated version supports Java 17 syntax.

rluble commented 1 month ago

Let me check if it breaks anything internally...

niloc132 commented 1 month ago

For GWT, we found that 4.27 was the highest we could go without changing how the build works, though some visitor changes were still necessary. Past that point required a minimum of Java 17 to run, and new jdt-core dependencies, plus something changed about how the compiler tooling is loaded. We didn't work that last piece out, but just updated to 4.27 to add Java 17 support while still keeping support to run on Java 11.

treblereel commented 1 month ago

For GWT, we found that 4.27 was the highest we could go without changing how the build works, though some visitor changes were still necessary. Past that point required a minimum of Java 17 to run, and new jdt-core dependencies, plus something changed about how the compiler tooling is loaded. We didn't work that last piece out, but just updated to 4.27 to add Java 17 support while still keeping support to run on Java 11.

Well, 4.22 requires no additional changes (at least from what I see), so it could be a good starting point for now. If it works, I'll try to push 4.27 later. Ideally it would be great to jump to 4.32 (with java21), but it drops java11, as far as I remember, it requires java17 min