Fix #23, fix #33: close uploadStub when closing PhotosLibraryClient

google / java-photoslibrary

Java client library for the Google Photos Library API

http://developers.google.com/photos

Apache License 2.0

107 stars 64 forks source link

Fix #23, fix #33: close uploadStub when closing PhotosLibraryClient #40

Closed mixin82 closed 3 years ago

jfschmakeit commented 3 years ago

I have just filed a request with the gapic-generator-java team here: https://github.com/googleapis/gapic-generator-java/issues/650

In the meantime we should be able to submit this and roll this into a new release. Please stay tuned.

mixin82 commented 3 years ago

Apologies @jfschmakeit, I thought I changed my column width...I should have checked anyway. Should be good now. Thanks

jfschmakeit commented 3 years ago

Great - thanks for bearing with me through the review! We are all good to merge this into a new release.

(Unfortunately the gapic team isn't going to take our proposal on board, so we'll have to do some pre-processing on our end. We can merge this manual change in for now and update our pipeline to include this in the future.)