google / java-photoslibrary

Java client library for the Google Photos Library API
http://developers.google.com/photos
Apache License 2.0
108 stars 59 forks source link

Fix large file upload issue #5

Closed xmani76 closed 5 years ago

xmani76 commented 5 years ago

If I try to upload a large file (file size > Integer.MAX_SIZE), I get a NumberFormatException from the updated line. Changing the Integer.parseInt to a Long.parseLong solves the problem.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
xmani76 commented 5 years ago

I signed the CLA

googlebot commented 5 years ago

CLAs look good, thanks!

jfschmakeit commented 5 years ago

Thanks for submitting the pull request (and signing the CLA)!

We'll take a look, please be patient as I'll need to loop in the right folks for a review.

jfschmakeit commented 5 years ago

Looks good, thanks for your pull request!