Support for complex parameter optimization - Nonlinear Conjugate Gradient

google / jaxopt

Hardware accelerated, batchable and differentiable optimizers in JAX.

https://jaxopt.github.io

Apache License 2.0

939 stars 66 forks source link

Support for complex parameter optimization - Nonlinear Conjugate Gradient #481

Closed geggo closed 1 year ago

geggo commented 1 year ago

Similar to #468, this PR adds support for optimization of complex variables for the NonlinearCG() routine, with tests comparing against the equivalent real case.

geggo commented 1 year ago

...it also contains the changes for PR #468, only last three commits are different.

vroulet commented 1 year ago

Hello again Gregor! Could you do the following: 1) sync the main branch of your fork with the main branch of this repository, 2) merge your synced branch into your feature-complex-NNG branch, fix all conflicts,

This will greatly simplify the review of this PR. Thanks!

geggo commented 1 year ago

Ok, merged main, file changes look ok, tests passed.