search

google / jaxopt

Hardware accelerated, batchable and differentiable optimizers in JAX.
https://jaxopt.github.io
Apache License 2.0
903 stars 62 forks source link

Fix `BoxOSQP` when configured with `fun` and used with pytree-based APIs #597

Open diegoferigo opened 1 month ago

diegoferigo commented 1 month ago

The combined usage of Pytree of matrices API and Quadratic function API is currently broken due to a missing operation performed on generic pytrees. This PR updates the operation to be performed with the existing pytree helpers.

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

diegoferigo commented 1 month ago

Failures in CI seem unrelated to the changes of this PR. The osqp_test.py, only test affected by the proposed changes, is passing.

diegoferigo commented 1 month ago

Friendly ping @Algue-Rythme, any comment on this tiny PR?