search

google / jetpack-camera-app

Apache License 2.0
116 stars 25 forks source link

Small Viewfinder API 24 and below (Only affects 9:16 aspect) #207

Open Sk8aaron opened 1 month ago

Sk8aaron commented 1 month ago

JCA version: 1.0.0

Device: physical LG-M153 API 23, emulator original Pixel API 24, emulator Pixel 7 Pro API 24,

Steps to reproduce: run app on device with API 24 or below and make sure 9:16 aspect ratio is selected.

Expected: viewfinder fits screen and has black bars where necessary

Observed: viewfinder size is very small and has over-sized black bars on bottom and right side

Remarks tested on API 21-35 with different resolutions this seems to only affect API 24 and below with 9:16 aspect.

emulator Pixel 7 Pro API 24 pixel7pro-API-24

emulator Pixel API 24 pixel-API-24

physical LG Fortune(M-153) API 23 9-16

yasith commented 1 month ago

@Sk8aaron We currently have an issue with rendering SurfaceView backed Viewfinder in API <= 24. Until the issue is fixed there. I've changed it so this app will use the EMBEDDED implementation mode (TextureView backed)