google / jetpack-camera-app

Apache License 2.0
116 stars 25 forks source link

Use nearest sensor aspect ratio for 1:1 #238

Closed temcguir closed 1 week ago

temcguir commented 1 week ago

1:1 is not a natively supported aspect ratio for CameraX. We had defaulted to using 4:3 and cropping since most sensors are 4:3. However, some emulators may use a 16:9 aspect ratio for their sensor, so we should instead use the aspect ratio which is closest to the sensor aspect ratio so we maximize support for emulators while also maximizing the FOV.