Before this PR:
Your code has been rated at 7.84/10
***** Module jetstream_pt.environment
environment.py:94:45: W0511: TODO (fixme)
environment.py:28:0: C0115: Missing class docstring (missing-class-docstring)
environment.py:28:0: R0902: Too many instance attributes (15/7) (too-many-instance-attributes)
environment.py:69:0: C0115: Missing class docstring (missing-class-docstring)
environment.py:69:0: R0902: Too many instance attributes (15/7) (too-many-instance-attributes)
environment.py:91:4: W0612: Unused variable 'Mesh' (unused-variable)
environment.py:117:2: C0116: Missing function or method docstring (missing-function-docstring)
environment.py:121:2: C0116: Missing function or method docstring (missing-function-docstring)
environment.py:125:4: W0212: Access to a protected member _elem of a client class (protected-access)
environment.py:125:52: W0212: Access to a protected member _elem of a client class (protected-access)
environment.py:127:2: C0116: Missing function or method docstring (missing-function-docstring)
environment.py:137:2: C0116: Missing function or method docstring (missing-function-docstring)
environment.py:143:2: C0116: Missing function or method docstring (missing-function-docstring)
environment.py:19:0: C0411: standard import "dataclasses" should be placed before third party imports "jax", "jax.sharding", "jax.experimental.mesh_utils" (wrong-import-order)
environment.py:20:0: C0411: standard import "typing.Tuple" should be placed before third party imports "jax", "jax.sharding", "jax.experimental.mesh_utils" (wrong-import-order)
environment.py:24:0: C0411: third party import "torch_xla2" should be placed before first party imports "jetstream_pt.third_party.llama2.model_args", "jetstream_pt.cache_manager" (wrong-import-order)
After this PR:
Your code has been rated at 10.00/10
Before this PR: Your code has been rated at 7.84/10 ***** Module jetstream_pt.environment environment.py:94:45: W0511: TODO (fixme) environment.py:28:0: C0115: Missing class docstring (missing-class-docstring) environment.py:28:0: R0902: Too many instance attributes (15/7) (too-many-instance-attributes) environment.py:69:0: C0115: Missing class docstring (missing-class-docstring) environment.py:69:0: R0902: Too many instance attributes (15/7) (too-many-instance-attributes) environment.py:91:4: W0612: Unused variable 'Mesh' (unused-variable) environment.py:117:2: C0116: Missing function or method docstring (missing-function-docstring) environment.py:121:2: C0116: Missing function or method docstring (missing-function-docstring) environment.py:125:4: W0212: Access to a protected member _elem of a client class (protected-access) environment.py:125:52: W0212: Access to a protected member _elem of a client class (protected-access) environment.py:127:2: C0116: Missing function or method docstring (missing-function-docstring) environment.py:137:2: C0116: Missing function or method docstring (missing-function-docstring) environment.py:143:2: C0116: Missing function or method docstring (missing-function-docstring) environment.py:19:0: C0411: standard import "dataclasses" should be placed before third party imports "jax", "jax.sharding", "jax.experimental.mesh_utils" (wrong-import-order) environment.py:20:0: C0411: standard import "typing.Tuple" should be placed before third party imports "jax", "jax.sharding", "jax.experimental.mesh_utils" (wrong-import-order) environment.py:24:0: C0411: third party import "torch_xla2" should be placed before first party imports "jetstream_pt.third_party.llama2.model_args", "jetstream_pt.cache_manager" (wrong-import-order)