google / jetstream-pytorch

PyTorch/XLA integration with JetStream (https://github.com/google/JetStream) for LLM inference"
Apache License 2.0
32 stars 14 forks source link

Fix run_interactive lint check #56

Closed FanhaiLu1 closed 4 months ago

FanhaiLu1 commented 4 months ago

After this PR: Your code has been rated at 10.00/10

Before this PR: Your code has been rated at 5.39/10

***** Module jetstream-pytorch.run_interactive run_interactive.py:119:0: C0301: Line too long (888/100) (line-too-long) run_interactive.py:120:0: C0301: Line too long (429/100) (line-too-long) run_interactive.py:121:0: C0301: Line too long (387/100) (line-too-long) run_interactive.py:122:0: C0301: Line too long (333/100) (line-too-long) run_interactive.py:32:0: E1101: Module 'absl.logging' has no 'getLogger' member (no-member) run_interactive.py:75:0: C0116: Missing function or method docstring (missing-function-docstring) run_interactive.py:80:2: W0612: Unused variable 'max_target_length' (unused-variable) run_interactive.py:100:0: C0116: Missing function or method docstring (missing-function-docstring) run_interactive.py:100:0: R0914: Too many local variables (22/15) (too-many-locals) run_interactive.py:132:21: E1102: engine.prefill is not callable (not-callable) run_interactive.py:135:19: E1102: engine.insert is not callable (not-callable) run_interactive.py:139:36: E1102: engine.generate is not callable (not-callable) run_interactive.py:100:9: W0613: Unused argument 'argv' (unused-argument) run_interactive.py:164:2: W0404: Reimport 'os' (imported line 26) (reimported) run_interactive.py:18:0: C0411: standard import "random" should be placed before third party imports "absl.app", "absl.flags", "absl.logging" (wrong-import-order) run_interactive.py:19:0: C0411: standard import "typing.List" should be placed before third party imports "absl.app", "absl.flags", "absl.logging" (wrong-import-order) run_interactive.py:26:0: C0411: standard import "os" should be placed before third party imports "absl.app", "absl.flags", "absl.logging", "jax", "jetstream.engine.token_utils", "colorama.Fore" (wrong-import-order) run_interactive.py:29:0: C0411: standard import "time" should be placed before third party imports "absl.app", "absl.flags", "absl.logging", "jax", "jetstream.engine.token_utils", "colorama.Fore" and first party import "jetstream_pt.engine" (wrong-import-order) run_interactive.py:164:2: C0412: Imports from package os are not grouped (ungrouped-imports)