google / jsinterop-base

Utilities for GWT and J2CL to interact with JavaScript beyond JsInterop
Apache License 2.0
67 stars 16 forks source link

Maven regards the current POM as invalid #2

Closed realityforge closed 6 years ago

realityforge commented 6 years ago

The POM generated by this project is invalid and generates warning such as the following when run through modern version of maven (3.5.3):

[WARNING] The POM for com.google.jsinterop:base:jar:1.0.0-RC1 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details

The problem is that the transitive dependency needs to be manually specified. Investigation seems to indicate that the problem is actually in the parent pom and simply updating to the latest parent pom fixes this.

The way to fix this is to change the pom output according to the following diff.

--- tmp/base-1.0.0-RC1.pom  2018-03-22 14:30:51.000000000 +1100
+++ /Users/peter/.m2/repository/com/google/jsinterop/base/1.0.0-RC1/base-1.0.0-RC1.pom  2018-03-22 14:30:54.000000000 +1100
@@ -6,7 +6,7 @@
   <parent>
     <groupId>org.sonatype.oss</groupId>
     <artifactId>oss-parent</artifactId>
-    <version>7</version>
+    <version>8</version>
   </parent>

   <groupId>com.google.jsinterop</groupId>

I am unfamiliar with the build system otherwise I would suggest the fix and assume that this should be a trivial fix for someone who is familiar.

If this is not the case then kick me and I can dive into it.

realityforge commented 6 years ago

It seems that this is not a problem with how elemental2 was published but a problem with proxies somehow caching incorrect dependency

Sorry for the noise