google / jsinterop-generator

Generates Java annotated with JsInterop from JavaScript extern sources
Apache License 2.0
75 stars 24 forks source link

Exit command with a non-zero exit code if the externs contain an error #31

Closed realityforge closed 5 years ago

realityforge commented 5 years ago

It should be noted that this is step 1 for achieving #28

jDramaix commented 5 years ago

In the last commits, I've introduced a Problems class I would prefer to add a reportError() to this class and change the implementation of hasErrors to return true if an error has been reported. When reportError returns true, the generator exits with a non-zero exit code

realityforge commented 5 years ago

Seems reasonable. I will reimplement it that way the next time I get back to this